Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added menuLeft and menuRight icons #1797

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Added menuLeft and menuRight icons #1797

merged 3 commits into from
Apr 4, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Apr 4, 2019 •
edited
Loading

Screen Shot 2019-04-04 at 11 34 10 AM

Screen Shot 2019-04-04 at 11 34 16 AM

And updated EuiNavDrawer’s collapse/expand button to use it

Screen Shot 2019-04-04 at 11 35 16 AM

Screen Shot 2019-04-04 at 11 35 21 AM

Checklist

  • [ ] This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

Added menuLeft and menuRight icons
cf0d1d5 
And updated EuiNavDrawer’s collapse/expand button to use it
@cchaos cchaos requested review from snide and ryankeairns April 4, 2019 15:42
@cchaos cchaos added the icons label Apr 4, 2019
ryankeairns
ryankeairns approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out, LGTM!

snide
snide approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loaded locally, scanned code. Good addition.

@cchaos cchaos merged commit 0f24882 into elastic:master Apr 4, 2019
@cchaos cchaos deleted the menu-direction-icons branch April 4, 2019 20:03
@snide snide mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchaos @snide @ryankeairns